This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Add broker ingress readiness prober #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yolocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think one thing we could check is if ALL brokers in the configmap are not ready, then the ingress is not ready. But this doesn't help with a subset of brokers being unready. The ingress also checks the broker readiness anyway, so not a big deal. /lgtm |
|
/retest |
1 similar comment
|
/retest |
|
The following jobs failed:
Job pull-google-knative-gcp-wi-tests expended all 3 retries without success. |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1060
It doesn't seem we need any special readiness check.
Proposed Changes
Release Note
Docs